Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support_settings #81

Merged
merged 1 commit into from
Oct 14, 2021
Merged

support_settings #81

merged 1 commit into from
Oct 14, 2021

Conversation

AdiAr11
Copy link
Contributor

@AdiAr11 AdiAr11 commented Oct 14, 2021

I've added support button addressing issue #75 which would take user to github repo upon clicking it

@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 14, 2021

I've implemented this button again to resolve the conflicts. Hope this is good now. I should add Talk To Us button after this gets merged right to avoid conflicts? Thank you

support_button.mp4

@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change labels Oct 14, 2021
justdvnsh
justdvnsh approved these changes Oct 14, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @AdiAr11 Thanks for your contributions

@justdvnsh justdvnsh merged commit 8ad409b into justdvnsh:develop Oct 14, 2021
@AdiAr11 AdiAr11 deleted the support_settings branch October 15, 2021 06:04
@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 15, 2021

LGTM. @AdiAr11 Thanks for your contributions

Thank you !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdiAr11 @justdvnsh