created new db for cache and moved cache functionality to cache db to fix #74 #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @justdvnsh , made a new db for cache and moved all cache related functionality . Now the cache data is not shown in favorites tab . 20211012_202808.mp4Here is the screen recording of it , please do let me know if anything can be improved or changed . |
|
@justdvnsh please go through the code and do let me know if anything needs to be changed . |
justdvnsh
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Hi @krishnachaitanya0107 The code looks good to me. Thank you for your contributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.