Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about_in_settings addressing issue #3 #73

Merged
merged 1 commit into from
Oct 12, 2021
Merged

about_in_settings addressing issue #3 #73

merged 1 commit into from
Oct 12, 2021

Conversation

AdiAr11
Copy link
Contributor

@AdiAr11 AdiAr11 commented Oct 11, 2021

I've added About us button in settings page which addresses issue #3 and displays information when clicked

@justdvnsh
Copy link
Owner

Hi @AdiAr11 . can you provide a screenshot of the same.

@justdvnsh justdvnsh added changes-requested attached when a change is requested in the PR. hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged labels Oct 11, 2021
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the files. the code looks good to me. Just make sure to include screenshots in the case of a ui change

@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 12, 2021

I have reviewed the files. the code looks good to me. Just make sure to include screenshots in the case of a ui change

very sorry, i'll add the screenshots and take care of it next time.

@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 12, 2021

settings_about1
settings_about2
settings_about3

Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AdiAr11 Looks good to me. Thank you for your contributions. Happy coding.

@justdvnsh justdvnsh merged commit cec259e into justdvnsh:develop Oct 12, 2021
@AdiAr11
Copy link
Contributor Author

AdiAr11 commented Oct 12, 2021

@AdiAr11 Looks good to me. Thank you for your contributions. Happy coding.

thank you so much !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested attached when a change is requested in the PR. hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants