Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SharedPreference #71

Merged
merged 17 commits into from
Oct 13, 2021
Merged

Added SharedPreference #71

merged 17 commits into from
Oct 13, 2021

Conversation

yash-k9
Copy link
Contributor

@yash-k9 yash-k9 commented Oct 10, 2021

No description provided.

justdvnsh
justdvnsh requested changes Oct 12, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yash-k9. I have reviewed the file. Please make the required changes. Thank your for your contributions

app/src/main/java/divyansh/tech/animeclassroom/common/Constants.kt Outdated Show resolved Hide resolved
app/src/main/java/divyansh/tech/animeclassroom/common/Constants.kt Outdated Show resolved Hide resolved
@justdvnsh justdvnsh added changes-requested attached when a change is requested in the PR. hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged labels Oct 12, 2021
@yash-k9
Copy link
Contributor Author

yash-k9 commented Oct 12, 2021

Hi @justdvnsh, I've made the changes. please review

justdvnsh
justdvnsh approved these changes Oct 13, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yash-k9. Looks good to me . Thank you for your contributions

@justdvnsh justdvnsh merged commit 0edc782 into justdvnsh:develop Oct 13, 2021
@justdvnsh justdvnsh mentioned this pull request Oct 13, 2021
Closed
@justdvnsh justdvnsh removed the changes-requested attached when a change is requested in the PR. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yash-k9 @justdvnsh @yash-57 @pauliancu97