Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/favorites animes page #57

Merged
merged 2 commits into from
Oct 10, 2021
Merged

Feature/favorites animes page #57

merged 2 commits into from
Oct 10, 2021

Conversation

pauliancu97
Copy link
Contributor

@pauliancu97 pauliancu97 commented Oct 9, 2021 •
edited
Loading

Implemented the favorites animes page. Also added a text for the case when the favorites anime list is empty. Closes #51
Screenshot_20211009-210156_AnimeClassroom
Screenshot_20211009-210046_AnimeClassroom

justdvnsh
justdvnsh approved these changes Oct 10, 2021
View reviewed changes
Copy link
Owner

@justdvnsh justdvnsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.Thank you so much for your contribution. Please star the repo if not already. It really helps us a lot. Thanks

@justdvnsh justdvnsh added hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change labels Oct 10, 2021
@justdvnsh justdvnsh merged commit df0b2cf into justdvnsh:develop Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justdvnsh justdvnsh justdvnsh approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Attached when pr is ready to merge and can be counted for hacktoberfest. ready-to-merge attached when a pr is ready to be merged UI-change Label to put if there is any UI change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate the Anime screen of favorites fragment with the saved data.
2 participants
@pauliancu97 @justdvnsh