General error layout #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into general-error-layout
…into general-error-layout
…ar12/AnimeClassroom into general-error-layout
|
@shivamparihar12 . I am accepting this PR, and i will delete the .idea files myself. But for further Pr's please make sure to update your repo with develop branch. It has the .gitignore file which will automatically ignore the .git files from the commit. |
|
Also, before i merge the pr, can you share a screenshot of the layout ? |
|
Thanks and sorry for the trouble. |
|
@shivamparihar12 No worries. I can handle that. Also, please star the repo, and thanks for your contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here is the another pr. since there are no conflicts and .idea files are also deleted then i guess this one must be fine. if not so then please tell what should i do now.