process library - remove fds from event loop before closing

just-js · Feb 18, 2021 · b79fc1d · b79fc1d
1 parent 32a5c12
commit b79fc1d
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/lib/process.js b/lib/process.js
@@ -87,11 +87,17 @@ function watch (p) {
     const timer = just.setInterval(() => {
       const [status, kpid] = waitpid(new Uint32Array(2), p.pid)
       if (kpid === p.pid) {
-        just.sys.nextTick(() => just.clearInterval(timer))
+        // todo - if our child process has children stdio buffers could still have data
+        just.sys.nextTick(() => {
+          just.clearInterval(timer)
+          loop.remove(p.stdin[WRITABLE])
+          close(p.stdin[WRITABLE])
+          loop.remove(p.stdout[READABLE])
+          close(p.stdout[READABLE])
+          loop.remove(p.stderr[READABLE])
+          close(p.stderr[READABLE])
+        })
         resolve(status)
-        close(p.stdin[WRITABLE])
-        close(p.stdout[READABLE])
-        close(p.stderr[READABLE])
       }
     }, 10)
   })