Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-esbuild): expose current target to index html transform #1877

Merged

Conversation

mattlewis92
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

The current target is not exposed to the index html transform

What is the new behavior?

The current target is exposed to the index html transform to match the behaviour in the webpack builder which does expose the current build target

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@mattlewis92 mattlewis92 force-pushed the expose-target-to-index-transform branch from a5fd600 to b9174c6 Compare November 25, 2024 14:42
@mattlewis92 mattlewis92 force-pushed the expose-target-to-index-transform branch from b9174c6 to a9a5086 Compare November 26, 2024 14:00
@arturovt arturovt requested a review from just-jeb November 28, 2024 17:04
@stefankoserkov
Copy link

will this PR make be merged, it will be nice to have the target options?

@arturovt arturovt merged commit 78e2006 into just-jeb:master Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants