Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error #7061

Merged
merged 1 commit into from
Jan 22, 2025
Merged

feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error #7061

merged 1 commit into from
Jan 22, 2025

Conversation

cookieg13
Copy link
Contributor

@cookieg13 cookieg13 commented Jan 17, 2025 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

To consume transaction id for some error cases , where currently its not consumed for Adyen, Worldpay. This PR addresses this issue.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Could not manually trigger error

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@cookieg13 cookieg13 requested a review from a team as a code owner January 17, 2025 11:28
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Jan 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector/adyen.rs  0% smaller

@cookieg13 cookieg13 self-assigned this Jan 17, 2025
@cookieg13 cookieg13 added the A-connector-integration Area: Connector integration label Jan 17, 2025
mrudulvajpayee4935
mrudulvajpayee4935 reviewed Jan 17, 2025
View reviewed changes
Copy link
Contributor

@mrudulvajpayee4935 mrudulvajpayee4935 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to use correlation_id as connector_transaction_id here?

@cookieg13 cookieg13 force-pushed the connectorTxnIdFix branch 2 times, most recently from 6697c13 to 2b85ce1 Compare January 20, 2025 09:46
@cookieg13 cookieg13 changed the title feat(connector): [ADYEN, WORLDPAY ] Consume transaction id for error cases feat(connector): [ADYEN ] Consume transaction id for PaymentsPreProcessing error Jan 20, 2025
@cookieg13
Copy link
Contributor Author

do we need to use correlation_id as connector_transaction_id here?

not needed, I have removed this

@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 21, 2025
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 199d176 Jan 22, 2025
19 of 20 checks passed
@likhinbopanna likhinbopanna deleted the connectorTxnIdFix branch January 22, 2025 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrudulvajpayee4935 mrudulvajpayee4935 mrudulvajpayee4935 approved these changes

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu approved these changes

Assignees

@cookieg13 cookieg13

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cookieg13 @deepanshu-iiitu @mrudulvajpayee4935 @likhinbopanna