Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add service details field in authentication table #6757

Merged
merged 13 commits into from
Dec 12, 2024

Conversation

sahkal
Copy link
Contributor

@sahkal sahkal commented Dec 5, 2024

Type of Change

  • New feature

Description

Add service details struct in payments request api_model and authentication table for storing service_details during click to pay authentication via unified_authentication_service

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema

How did you test it?

Currently we cannot test it as the flow to invoke service details into authentication table is not yet ready, this is a micro pr for the setup

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code

@sahkal sahkal self-assigned this Dec 5, 2024
@sahkal sahkal requested review from a team as code owners December 5, 2024 14:23
Copy link

semanticdiff-com bot commented Dec 5, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  api-reference-v2/openapi_spec.json  0% smaller
  api-reference/openapi_spec.json  0% smaller
  crates/api_models/src/payments.rs  0% smaller
  crates/diesel_models/src/authentication.rs  0% smaller
  crates/diesel_models/src/schema.rs  0% smaller
  crates/diesel_models/src/schema_v2.rs  0% smaller
  crates/hyperswitch_domain_models/src/router_request_types/unified_authentication_service.rs  0% smaller
  crates/openapi/src/openapi.rs  0% smaller
  crates/openapi/src/openapi_v2.rs  0% smaller
  crates/router/src/core/authentication/utils.rs Unsupported file format
  crates/router/src/core/payments.rs  0% smaller
  crates/router/src/core/payments/operations/payment_approve.rs  0% smaller
  crates/router/src/core/payments/operations/payment_cancel.rs  0% smaller
  crates/router/src/core/payments/operations/payment_capture.rs  0% smaller
  crates/router/src/core/payments/operations/payment_complete_authorize.rs  0% smaller
  crates/router/src/core/payments/operations/payment_confirm.rs  0% smaller
  crates/router/src/core/payments/operations/payment_create.rs  0% smaller
  crates/router/src/core/payments/operations/payment_post_session_tokens.rs  0% smaller
  crates/router/src/core/payments/operations/payment_reject.rs  0% smaller
  crates/router/src/core/payments/operations/payment_session.rs  0% smaller
  crates/router/src/core/payments/operations/payment_start.rs  0% smaller
  crates/router/src/core/payments/operations/payment_status.rs  0% smaller
  crates/router/src/core/payments/operations/payment_update.rs  0% smaller
  crates/router/src/core/payments/operations/payments_incremental_authorization.rs  0% smaller
  crates/router/src/core/payments/operations/tax_calculation.rs  0% smaller
  crates/router/src/core/unified_authentication_service.rs  0% smaller
  crates/router/src/core/unified_authentication_service/transformers.rs  0% smaller
  crates/router/src/db/authentication.rs  0% smaller
  migrations/2024-12-05-115544_add-service-details/down.sql Unsupported file format
  migrations/2024-12-05-115544_add-service-details/up.sql Unsupported file format

@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Dec 5, 2024
@hyperswitch-bot hyperswitch-bot bot added the M-api-contract-changes Metadata: This PR involves API contract changes label Dec 6, 2024
@sahkal sahkal added this to the December 2024 Release milestone Dec 6, 2024
@sahkal sahkal removed the request for review from a team December 11, 2024 12:58
@sahkal sahkal added the A-core Area: Core flows label Dec 11, 2024
Comment on lines 1023 to 1026
pub struct ServiceDetails {
pub merchant_transaction_id: Option<String>,
pub correlation_id: Option<String>,
pub x_src_flow_id: Option<String>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add documentation for all the fields ?
NIT: Name x_src_flow_id better

@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 12, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit e9a5615 Dec 12, 2024
16 of 18 checks passed
@Gnanasundari24 Gnanasundari24 deleted the add-service-details-field-in-authentication-table branch December 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows M-api-contract-changes Metadata: This PR involves API contract changes M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants