-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Add service details field in authentication table #6757
Merged
Gnanasundari24
merged 13 commits into
main
from
add-service-details-field-in-authentication-table
Dec 12, 2024
Merged
feat(core): Add service details field in authentication table #6757
Gnanasundari24
merged 13 commits into
main
from
add-service-details-field-in-authentication-table
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperswitch-bot
bot
added
the
M-database-changes
Metadata: This PR involves database schema changes
label
Dec 5, 2024
hyperswitch-bot
bot
added
the
M-api-contract-changes
Metadata: This PR involves API contract changes
label
Dec 6, 2024
sai-harsha-vardhan
previously approved these changes
Dec 11, 2024
crates/api_models/src/payments.rs
Outdated
Comment on lines
1023
to
1026
pub struct ServiceDetails { | ||
pub merchant_transaction_id: Option<String>, | ||
pub correlation_id: Option<String>, | ||
pub x_src_flow_id: Option<String>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add documentation for all the fields ?
NIT: Name x_src_flow_id
better
ShankarSinghC
approved these changes
Dec 12, 2024
deepanshu-iiitu
approved these changes
Dec 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Dec 12, 2024
Gnanasundari24
deleted the
add-service-details-field-in-authentication-table
branch
December 12, 2024 12:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
M-api-contract-changes
Metadata: This PR involves API contract changes
M-database-changes
Metadata: This PR involves database schema changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Add service details struct in payments request api_model and authentication table for storing service_details during click to pay authentication via unified_authentication_service
Additional Changes
How did you test it?
Currently we cannot test it as the flow to invoke service details into authentication table is not yet ready, this is a micro pr for the setup
Checklist
cargo +nightly fmt --all
cargo clippy