-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLite 0.6.0a0 #160
Conversation
"@jupyterlab/coreutils": "^6.1.1", | ||
"@jupyterlite/contents": "^0.5.0", | ||
"@jupyterlite/kernel": "^0.5.0", | ||
"@jupyterlab/coreutils": "^6.4.0-alpha.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also bumping these @jupyterlab
packages, since jupyterlite-pyodide-kernel
already closely follows jupyterlite-core
releases, and jupyterlite-core
follows minor JupyterLab releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, but same old question: how can we make this more predictable, and based on the truth from upstream's yarn.lock
and package.json
, and then doubly upstream's staging
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What kind of predictability are we expecting?
In this case these @jupyterlab
packages are used more like in regular extensions, and it's mostly minimal use of @jupyterlab/coreutils
and @jupyterlab/services
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're sticking with jlpm
as the main task entry point:
jlpm
jlpm deduplicate
jlpm lint:upstreams
... and it checks vs a single source of truth that the not-going-to-space-if-wrong versions from the currently-installed python and js upstreams. It doesn't even have to fix them, just tell us what is wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or, perhaps it would be more appropriate as a pytest which only runs if it's in a git checkout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so probably something we could look into separately.
@bollwyvl if that's ok, maybe we can go with this and I'll follow up with a pre-release right after? Unless you had more comments or inputs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't really hurt anybody!
Maybe we can first merge #161 to have it in |
Created and re-targeted #161 against |
(feel free to re-re- target, and release in whatever order makes sense, likely won't be doing any |
ok no problem, I think we can still have #161 target |
Update to https://github.com/jupyterlite/jupyterlite/releases/tag/v0.6.0a0
Clean up some other jest related packages that don't seem to be used at the moment.