Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to JupyterLite 0.6.0a0 #160

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Update to JupyterLite 0.6.0a0 #160

merged 1 commit into from
Jan 17, 2025

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 17, 2025

Update to https://github.com/jupyterlite/jupyterlite/releases/tag/v0.6.0a0

Clean up some other jest related packages that don't seem to be used at the moment.

Copy link
Contributor

lite-badge 👈 Try it on ReadTheDocs

"@jupyterlab/coreutils": "^6.1.1",
"@jupyterlite/contents": "^0.5.0",
"@jupyterlite/kernel": "^0.5.0",
"@jupyterlab/coreutils": "^6.4.0-alpha.2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bumping these @jupyterlab packages, since jupyterlite-pyodide-kernel already closely follows jupyterlite-core releases, and jupyterlite-core follows minor JupyterLab releases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but same old question: how can we make this more predictable, and based on the truth from upstream's yarn.lock and package.json, and then doubly upstream's staging?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of predictability are we expecting?

In this case these @jupyterlab packages are used more like in regular extensions, and it's mostly minimal use of @jupyterlab/coreutils and @jupyterlab/services.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're sticking with jlpm as the main task entry point:

jlpm
jlpm deduplicate
jlpm lint:upstreams

... and it checks vs a single source of truth that the not-going-to-space-if-wrong versions from the currently-installed python and js upstreams. It doesn't even have to fix them, just tell us what is wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, perhaps it would be more appropriate as a pytest which only runs if it's in a git checkout.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so probably something we could look into separately.

@jtpio jtpio added this to the 0.6.0 milestone Jan 17, 2025
@jtpio jtpio marked this pull request as ready for review January 17, 2025 15:03
@jtpio
Copy link
Member Author

jtpio commented Jan 17, 2025

@bollwyvl if that's ok, maybe we can go with this and I'll follow up with a pre-release right after? Unless you had more comments or inputs?

Copy link
Contributor

@bollwyvl bollwyvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't really hurt anybody!

@jtpio
Copy link
Member Author

jtpio commented Jan 17, 2025

Maybe we can first merge #161 to have it in 0.5.2?

@bollwyvl
Copy link
Contributor

Created and re-targeted #161 against 0.5.x

@bollwyvl
Copy link
Contributor

(feel free to re-re- target, and release in whatever order makes sense, likely won't be doing any conda-forge chores much longer today, but again, probably won't hurt anybody)

@jtpio
Copy link
Member Author

jtpio commented Jan 17, 2025

ok no problem, I think we can still have #161 target main and then we backport to 0.5.x (usually how we do with other repos). I'll have a look!

@jtpio jtpio mentioned this pull request Jan 17, 2025
4 tasks
@jtpio jtpio merged commit bf25ce6 into jupyterlite:main Jan 17, 2025
14 of 15 checks passed
@jtpio jtpio deleted the lite-060a0 branch January 17, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants