Change the Drag class's private method _moveDragImage to a public method moveDragImage.

[ghost]

Hi, my name is Logan McNichols. I am an intern for Jupyter Cal Poly. I am working on a tabular data editor powered by the datagrid along with @kgoo124 and @ryuntalan.

We would like to use lumino's Drag class to create a column/row shadow which appears on a mouse click of a column/row header and is drag-able. The movement of this shadow can't just follow the cursor wherever it goes, but must be constrained to the bounds of the DataGrid. This PR would allow us to do this, by letting us extend Drag and make modifications to moveDragImage.

This PR would rename _moveDragImage to moveDragImage and update it's implementations to reflect this change. It would remove the private access modifier and relocate moveDragImage to the area where the other public methods are.

fixes #95

[vidartf]

If the goal is only to be able to override the method when subclassed, I would say protected is a better middle ground than making it public.

[afshin]

@lmcnichols Does Vidar's suggestion of making this method protected still satisfy your use case?

[ghost]

Yes it still does. I added the protected access modifier to moveDragImage

[blink1073]

Nice, thanks!

[blink1073]

Released @lumino/datagrid@0.12.0

[ghost]

Hi @blink1073! I'm running into an issue related to this PR. When I jlpm install @lumino/dragdrop@1.6.4 I get the correct package locally. My local @lumino/dragdrop/dist/index.es6.js is correct. But then when I spin up jupyter lab and look at the same directory I seem to get an older version with _moveDragImage instead of moveDragImage. Drag behavior also reverts to the default behavior w/out the bounds. I was just wondering if off the top of your head you know what's going on. I really appreciate the help!

[blink1073]

I believe it is because JupyterLab itself is using the older version and enforcing it using resolutions, we'd need a release of JupyterLab with the newer versions

[ghost]

Okay that makes sense. Thanks for the help!