Make cursorForHandle and it's argument type accessible from outside BasicMouseHandler. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d. Changed the implementations of cursorForHandle in BasicMouseHandler from Private.cursorForHandle(handle) to this.cursorForHandle(handle). Made ResizeHandle and exported type.
|
Hi @lmcnichols ! I'm afk for the night, will look at this tomorrow. |
|
Sounds good! Thanks |
|
Released as |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, my name is Logan McNichols. I am an intern for Jupyter Cal Poly, working with @kgoo124 and @ryuntalan to develop a tabular data editor powered by the
DataGrid. We want to add a grab cursor for moving rows and columns. The classBasicMouseHandlerin the package@lumino/datagridprovides much of the core functionality we need, but it is difficult modify the default cursor behavior.This pull request would move the method
cursorForHandlefrom thePrivatenamespace to a public method within theBasicMouseHandlerclass. Implementations ofcursorForHandleinBasicMouseHandlerwould be updated to reflect this change. The typeResizeHandlewould be exported as well so that classes extendingBasicMouseHandlercould create custom versions ofcursorForHandle.Fixes #91