Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsubscribe from grid wheel events on editor dispose #80

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

mbektas
Copy link
Member

@mbektas mbektas commented Jun 9, 2020

make sure cell editor unsubscribes from grid's wheel messages when editor is disposed

fixes #62

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 87ddf3c into jupyterlab:master Jun 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cell editing using old model state when repainting, following a data model change
2 participants