Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-live to the tab bar to improve screen reader accessibility. #627

Closed
wants to merge 13 commits into from
Closed

Added aria-live to the tab bar to improve screen reader accessibility. #627

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ca3e202
Added command dialog to tcommand palette commands for screen reader a…
m158261 Aug 30, 2023
5c8cbd4
Merge branch 'main' of github.com:m158261/lumino into command-dialog
m158261 Aug 30, 2023
922ce77
Changed label with same functionality as command dialog
m158261 Sep 1, 2023
c51a384
Merge branch 'jupyterlab:main' into command-dialog
m158261 Oct 3, 2023
fa76dc9
Merge branch 'command-dialog' of github.com:m158261/lumino into comma…
m158261 Oct 3, 2023
f7e058b
Added aria live to label dev
m158261 Oct 3, 2023
cb9356b
Merge branch 'jupyterlab:main' into command-dialog
m158261 Oct 23, 2023
40e91c9
Merge branch 'jupyterlab:main' into command-dialog
m158261 Nov 2, 2023
b36101e
Tidied up branch
m158261 Nov 2, 2023
663af78
Changed assertive to polite
m158261 Nov 2, 2023
ad89b00
Merge branch 'jupyterlab:main' into command-dialog
m158261 Nov 8, 2023
5b121d0
Simplified aria-live region and moved it from command palette to tab bar
m158261 Nov 8, 2023
098d265
Merge branch 'jupyterlab:main' into command-dialog
m158261 Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/widgets/src/commandpalette.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,7 +860,7 @@ export namespace CommandPalette {
*/
renderItemLabel(data: IItemRenderData): VirtualElement {
let content = this.formatItemLabel(data);
return h.div({ className: 'lm-CommandPalette-itemLabel', "aria-label": `${content}`, 'id': `${content}`.toLowerCase().replace(/ /g, '') }, content);
return h.div({ className: 'lm-CommandPalette-itemLabel', 'aria-live': "assertive", "aria-label": `${content}`, 'id': `${content}`.toLowerCase().replace(/ /g, '') }, content);
m158261 marked this conversation as resolved.
Show resolved Hide resolved
}

/**
Expand Down