Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make IOverflowMenuOptions.title optional #550

Merged
merged 6 commits into from
Mar 6, 2023

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Mar 4, 2023

Right now it looks like it's possible to disable the overflow menu for a menu bar with:

const overflowOptions = {
  overflowMenuOptions: { isVisible: false, title: '' }
};

However title still needs to be provided even if isVisible is set to false.

This change makes title optional so this does not have to be the case anymore:

const overflowOptions = {
  overflowMenuOptions: { isVisible: false }
};

overflowMenuOptions.overflowMenuVisible has been renamed overflowMenuOptions.isVisible

@jtpio jtpio added the enhancement New feature or request label Mar 4, 2023
fcollonval and others added 2 commits March 6, 2023 15:19
Co-authored-by: Afshin Taylor Darian <git@darian.email>
@fcollonval fcollonval merged commit 6874644 into jupyterlab:main Mar 6, 2023
@jtpio jtpio deleted the optional-title branch March 6, 2023 16:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants