Check for hidden items before re-rendering

[alec-kr]

This PR fixes issue #13677 from jupyterlab.

Issue

Hidden items are still being re-rendered, despite the fact that they shouldn't be.

Solution

Added a check to onUpdateRequest to determine if an item is hidden, before re-rendering it. This will prevent hidden items from being re-rendered, thus solving the issue.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[fcollonval]

Thanks @alec-kr

Could you trigger an update when the command palette is visible? This will ensure we apply the command palette updates shunted when it was hidden.

protected onAfterShow(msg: Message): {
  this.update();
  super.onAfterShow(msg);
}

Reference inherited method:

lumino/packages/widgets/src/widget.ts

Line 670 in 38757e2

protected onAfterShow(msg: Message): void {}

[alec-kr]

Sure! I've updated the method. Is this correct?

Edit: I definitely didn't do this right. Where exactly should this change be made? Sorry about the confusion

[fcollonval]

Sure! I've updated the method. Is this correct?

Edit: I definitely didn't do this right. Where exactly should this change be made? Sorry about the confusion

Sorry my fault I mislead you by referring to the inherited method. You need to add my snippet within the CommandPalette class; for example there:

lumino/packages/widgets/src/commandpalette.ts

Line 274 in e1e1b11

[fcollonval]

Thanks @alec-kr

[alec-kr]

Thank you for your patience 😄

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️