IRenderer cleanup; normalize icon fields across all interfaces #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
|
I've now implemented everything I described in the top post, and added a bunch of extra tests to cover all of the new |
blink1073
approved these changes
Feb 10, 2020
|
Released:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for jupyterlab/jupyterlab#7864
This PR has two goals:
I recently got this bit of feedback from one of the
LabIconearly adopters (@vidartf via gitter):He was talking about figuring out that
Title.iconRendererwas the field you're supposed to pass aLabIconobject into. Which, fair point, it's pretty confusing thatLabIcongets passed into theFoo.iconfield for all interfaces except those defined in Lumino. On top of that,iconRendereras a name is kind of clunky and maybe a bit conceptually confusing. Given all that, I want to experiment with reclaiming the deprecatedTitle.iconfield, and see if I can do so in a backwards compatible wayGiven that it's possible to reclaim
Title.icon, I want to normalize the behavior of the.iconfield in all of the relevant interfaces across Lumino, so that all icons in Lumino are able to use custom renderers. Once that's done, I'll be able to finally migrate the last few holdout icons in Jupyterlab toLabIconand resolve the remaining issues with that (see Post LabIcon cleanup; migrate last holdouts to LabIcon; fix icon styling jupyterlab#7864)There's also a minor fix to the custom renderer implementation in
virtualdomthat needs getting in (theattrsandchildrenargs currently aren't getting passed in to a custom renderer in a consistent fashion)