-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Internet Explorer from tests, add Webkit #416
Conversation
This doesn't work on my machine, even though I have a Mac. When I try to run
|
I suggest to switch to playwright as browser provider: see https://maksimrv.medium.com/unit-testing-javascript-with-karma-playwright-puppeteer-1d54139d422 That will help setting up test environment. |
@fcollonval, like this? My last commit adds Playwright as a dependency to all of the packages that have Karma tests. On my machine, I was able to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Closes #349.