Fix output.path for webpack 4
#35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for compatibility with webpack 4
This was referenced Dec 21, 2019
|
Good spot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #21 (comment)
Recently in #31, we upgraded the Webpack used to build the tests in all of the
@lumniopackages fromv2=>v4.Webpack
v4adds a default value tooutput.path:path.join(process.cwd(), 'dist'). So currently, while our tests sucessfully build, they end up in thetests/dist/builddir, and Karma can't find them. This makes all of our test cases empty but successful. This PR fixes that