Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow commands to accept partial json objects #32

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

blink1073
Copy link
Contributor

No description provided.

Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. This seems uncontroversial to me. Is there any downside?

@blink1073
Copy link
Contributor Author

I don't see any downside.

@blink1073 blink1073 merged commit feda52e into jupyterlab:master Dec 19, 2019
@blink1073
Copy link
Contributor Author

Published commands@1.9.0

@vidartf
Copy link
Member

vidartf commented Dec 20, 2019

This should probably be update as well then:

args?: ReadonlyJSONObject;

@vidartf
Copy link
Member

vidartf commented Dec 20, 2019

Note: I think this might break compilation of command implementor code, if strict null checks are on.

@vidartf
Copy link
Member

vidartf commented Dec 20, 2019

e.g.

// ...
execute: args => {
  return args['foo'].toString();
}
// ...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants