Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transposed display names for arrow keys #268

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Fix transposed display names for arrow keys #268

merged 1 commit into from
Dec 13, 2021

Conversation

thomasjm
Copy link
Contributor

Introduced in #258, CC @jasongrout

@welcome
Copy link

welcome bot commented Nov 25, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@krassowski krassowski added the bug Something isn't working label Nov 25, 2021
krassowski
krassowski approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thomasjm
Copy link
Contributor Author

thomasjm commented Dec 6, 2021

Could this be merged soon? I'd love a point release with the fix. Thanks!

@blink1073 blink1073 merged commit 578509c into jupyterlab:master Dec 13, 2021
@welcome
Copy link

welcome bot commented Dec 13, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@krassowski krassowski krassowski approved these changes

@vidartf vidartf vidartf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thomasjm @vidartf @krassowski @blink1073