Update title in AccordionPanel #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollonval
requested changes
Oct 14, 2021
There was a problem hiding this comment.
Thanks @hbcarlos
The logic is not the same than the one in the tab bar or the menu bar. But in this case it sounds better as the title are not rendered in a separated container as the previous case.
I added a comment in the code.
|
@hbcarlos, can you please add tests to the existing |
|
Sure! I'm on it! |
|
@blink1073 What test should I add to the layout? |
|
The panel should be enough, it is exercising the layout under the hood. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #248
I'm not sure if this is the right way of updating the title.
I'm not clearing the signals in the
disposemethod because it's done in the parent class Widget.Code changes
This PR adds a new handler to listen for changes in the titles of the accordion panel's children and replaces the corresponding title's HTMLElement.