Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't sort context menu item by selector #203

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Don't sort context menu item by selector #203

merged 1 commit into from
Jul 21, 2021

Conversation

fcollonval
Copy link
Member

Fixes #202

@welcome
Copy link

welcome bot commented Jul 21, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval fcollonval marked this pull request as ready for review July 21, 2021 10:09
@fcollonval
Copy link
Member Author

Error seems unrelated

blink1073
blink1073 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 added the enhancement New feature or request label Jul 21, 2021
@blink1073 blink1073 merged commit d09f1fc into jupyterlab:master Jul 21, 2021
@welcome
Copy link

welcome bot commented Jul 21, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

This was referenced Jul 21, 2021
Merged
Merged
@fcollonval fcollonval deleted the fcollonval/issue202 branch April 13, 2022 13:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't sort context menu item by selector
2 participants
@fcollonval @blink1073