Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection mode #179

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

ibdafna
Copy link
Member

@ibdafna ibdafna commented May 4, 2021

Signed-off-by: Itay Dafna i.b.dafna@gmail.com

This PR reverts the changes from commit 4a685fc as they break the selectionMode parameter of BasicSelectionModel, resulting in 'cell' selection regardless of the parameter passed to the constructor:

new BasicSelectionModel({
    dataModel: model6,
    selectionMode: "row", // won't work
  });

That change was arguably not needed to begin with as 'cell' selection mode will select full rows or columns when they are clicked on.

Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
@blink1073 blink1073 added the bug Something isn't working label May 4, 2021
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit 16e4bca into jupyterlab:master May 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants