Change one BasicMouseHandler properties from private to protected #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
vidartf
reviewed
Mar 30, 2021
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
Signed-off-by: Itay Dafna <i.b.dafna@gmail.com>
vidartf
reviewed
Apr 9, 2021
| get pressData(): PressData.PressData | null { | ||
| return this._pressData; | ||
| } | ||
|
|
There was a problem hiding this comment.
Doesn't this mean that this property will not be available on the public API anymore ?
There was a problem hiding this comment.
Yeah agreed. Can this be added back?
There was a problem hiding this comment.
Anyone able to make a PR?
There was a problem hiding this comment.
@blink1073 to revert this, I'll need to restore the variable name of pressData back to _pressData as the get pressData() and pressData attribute have duplicate identifiers. Unless you have other suggestions?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Itay Dafna i.b.dafna@gmail.com
Whilst the BasicMouseHandler class can be extended, it has two private properties, making extensions tricky to implement. This PR makes the the _pressData property protected instead of private.