Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouseDown now uses cell, column, and row selection modes #114

Merged
merged 2 commits into from
Aug 20, 2020

Conversation

kgoo124
Copy link
Contributor

@kgoo124 kgoo124 commented Aug 19, 2020

I am currently working on the Tabular Data Editor extension with @lmcnichols and @ryuntalan. We noticed the BasicMouseHandler doesn't utilize the different selection modes onMouseDown. This change would set the proper selectionMode during the onMouseDown() function. There are other places in the mouse handler where the grid is selecting certain areas, so those could also be changed as well.

Fixes #113

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit aca29d9 into jupyterlab:master Aug 20, 2020
@blink1073
Copy link
Contributor

cc @nmichaud I released the following changes:

 - @lumino/application: 1.10.4 => 1.11.0
 - @lumino/datagrid: 0.12.0 => 0.13.0
 - @lumino/datastore: 0.10.3 => 0.11.0
 - @lumino/default-theme: 0.4.4 => 0.5.0
 - @lumino/widgets: 1.13.4 => 1.14.0

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datagrid selection mode for mousedown
2 participants