-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give extending classes access to some of the data grid's paint utilities. #111
Conversation
…espace. Implementations updated.
…aintOverlay and changed their access modifiers from private to protected. Updated implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pushing the boundaries on the grid! Just a couple of comments
I'm not sure this is necessary - it's possible to leverage a combination of metadata and renderers to draw images/icons onto the grid. What are you trying to do in a subclass? |
@kgoo124 ah ok, that looks interesting! Definitely not possible with the current grid code. It looks like you want to draw on the canvas outside of the grid region. |
@nmichaud yes that's right. Since the ghost rows/columns serve as UI to add a new row/column, we want to be able to paint an extra row/column on the grid without having the manage the data model underneath it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hi, my name is Logan McNichols. I am an intern for Jupyter Cal Poly. I am working on a tabular data editor powered by the
DataGrid
along with @kgoo124 and @ryuntalan.We are working on a design that involves painting
LabIcons
onto theDataGrid
's canvas to correspond the the type of field in a given column. To achieve this, we would like to provide getters for some of theDataGrid
's properties and change someprivate
methods toprotected
.This PR would change the access modifier from
private
toprotected
on the following methods.paintContent
repaintContent
&
repaintOverlay
It would also add getters for the following properties.
_canvasGC
_rowSections
_columnSections
_columnHeaderSections
_rowHeaderSections
.Fixes #110