Skip to content

Commit

Permalink
Fix service type (#382)
Browse files Browse the repository at this point in the history
* Fix service types

* Control sha used to create the diff for license header changes

Co-authored-by: Frédéric Collonval <fcollonval@gmail.com>
  • Loading branch information
afshin and fcollonval authored Aug 30, 2022
1 parent d6a592c commit 6c04c98
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 10 deletions.
18 changes: 12 additions & 6 deletions .github/workflows/license-header.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,29 @@ jobs:
with:
mode: fix

- name: Get modified files in the staging directory
id: changed-files
uses: tj-actions/changed-files@v29.0.2

- name: Apply Changes
if: steps.changed-files.outputs.any_changed == 'true'
shell: bash -l {0}
run: |
git config user.name 'github-actions[bot]'
git config user.email 'github-actions[bot]@users.noreply.github.com'
git add *
git commit -m "Automatic application of license header"
git commit --allow-empty -m "Automatic application of license header"
- name: Get modified files in the staging directory
id: changed-files
uses: tj-actions/changed-files@v29.0.2
with:
base_sha: 'HEAD~1'
sha: 'HEAD'

- name: Push fixes
if: steps.changed-files.outputs.any_changed == 'true'
shell: bash -l {0}
run: |
echo "Changed files:"
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
echo " $file"
done
git config push.default upstream
git push
env:
Expand Down
4 changes: 2 additions & 2 deletions packages/application/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export interface IPlugin<T extends Application, U> {
* This function will not be called unless all of its required
* services can be fulfilled.
*/
activate: (app: T, ...args: Token<any>[]) => U | Promise<U>;
activate: (app: T, ...args: any[]) => U | Promise<U>;

/**
* A function invoked to deactivate the plugin.
Expand All @@ -113,7 +113,7 @@ export interface IPlugin<T extends Application, U> {
*
* @param args - The services specified by the `requires` property.
*/
deactivate?: ((app: T, ...args: Token<any>[]) => void | Promise<void>) | null;
deactivate?: ((app: T, ...args: any[]) => void | Promise<void>) | null;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions review/api/application.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ export namespace Application {

// @public
export interface IPlugin<T extends Application, U> {
activate: (app: T, ...args: Token<any>[]) => U | Promise<U>;
activate: (app: T, ...args: any[]) => U | Promise<U>;
autoStart?: boolean;
deactivate?: ((app: T, ...args: Token<any>[]) => void | Promise<void>) | null;
deactivate?: ((app: T, ...args: any[]) => void | Promise<void>) | null;
id: string;
optional?: Token<any>[];
provides?: Token<U> | null;
Expand Down

0 comments on commit 6c04c98

Please sign in to comment.