Use Firefox from playwright (#481)

* Use Firefox from playwright * Skip webkit on Ubuntu
jupyterlab · Nov 29, 2022 · 2731adf · 2731adf
1 parent 0bd799a
commit 2731adf
Show file tree

Hide file tree

Showing 16 changed files with 34 additions and 4 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -12,11 +12,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        browser: [chrome-headless, firefox-headless]
+        browser: [chrome-headless, firefox-headless, webkit-headless]
         exclude:
-          # macos and firefox-headless seems to consistently fail.
-          - os: macos-latest
-            browser: firefox-headless
+          # Playwright webkit binary is not compatible with ubuntu
+          - os: ubuntu-latest
+            browser: webkit-headless
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3

diff --git a/packages/algorithm/tests/karma.conf.js b/packages/algorithm/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/application/tests/karma.conf.js b/packages/application/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/collections/tests/karma.conf.js b/packages/collections/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/commands/tests/karma.conf.js b/packages/commands/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/coreutils/tests/karma.conf.js b/packages/coreutils/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/disposable/tests/karma.conf.js b/packages/disposable/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/domutils/tests/karma.conf.js b/packages/domutils/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/dragdrop/tests/karma.conf.js b/packages/dragdrop/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/keyboard/tests/karma.conf.js b/packages/keyboard/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/messaging/tests/karma.conf.js b/packages/messaging/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/polling/tests/karma.conf.js b/packages/polling/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/properties/tests/karma.conf.js b/packages/properties/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/signaling/tests/karma.conf.js b/packages/signaling/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/virtualdom/tests/karma.conf.js b/packages/virtualdom/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;
 

diff --git a/packages/widgets/tests/karma.conf.js b/packages/widgets/tests/karma.conf.js
@@ -3,6 +3,8 @@
  * Distributed under the terms of the Modified BSD License.
  */
 
+process.env.FIREFOX_BIN = require('playwright').firefox.executablePath();
+process.env.FIREFOX_HEADLESS_BIN = process.env.FIREFOX_BIN;
 process.env.WEBKIT_BIN = require('playwright').webkit.executablePath();
 process.env.WEBKIT_HEADLESS_BIN = process.env.WEBKIT_BIN;