Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't patch event loop for tornado 6.1+ #142

Merged
merged 3 commits into from
Dec 16, 2020
Merged

don't patch event loop for tornado 6.1+ #142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7eac03
don't patch event loop for tornado 6.1+
bollwyvl Dec 16, 2020
7b37be2
ci: py3.9, pypy3, some more pip metadata
bollwyvl Dec 16, 2020
68407fd
also upgrade wheel
bollwyvl Dec 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,19 @@ on:
jobs:
linux:
name: ${{ matrix.PLATFORM }} py${{ matrix.PYTHON_VERSION }}
runs-on: ${{ matrix.PLATFORM }}
runs-on: ${{ matrix.PLATFORM }}-latest
env:
CI: True
PYTHON_VERSION: ${{ matrix.PYTHON_VERSION }}
CODECOV_TOKEN: e025254a-fe54-4914-8890-0c26e7aa0d07
strategy:
fail-fast: false
matrix:
PYTHON_VERSION: ['3.6', '3.8']
PLATFORM: ['ubuntu-latest', 'macos-latest', 'windows-latest']
PYTHON_VERSION: ['3.6', '3.9', 'pypy3']
PLATFORM: ['ubuntu', 'macos', 'windows']
exclude:
- PLATFORM: windows
PYTHON_VERSION: pypy3
steps:
- name: Checkout
uses: actions/checkout@v1
Expand All @@ -37,12 +40,15 @@ jobs:
architecture: 'x64'
- name: Install python dependencies
run: |
pip install setuptools pip --upgrade --user
pip install setuptools pip wheel --upgrade --user
- name: Install project dependencies
run: |
pip install -v -e ".[test]"
- name: Show python environment
run: |
python --version
python -m pip list
python -m pip freeze
python -m pip check
- name: Run python tests
# See `setup.cfg` for full test options
run: |
Expand Down
2 changes: 1 addition & 1 deletion jupyterlab_server/tests/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
def maybe_patch_ioloop():
""" a windows 3.8+ patch for the asyncio loop
"""
if sys.platform.startswith("win"):
if sys.platform.startswith("win") and tornado.version_info < (6, 1):
if sys.version_info >= (3, 8):
import asyncio
try:
Expand Down