Fix off by one error in benchmark samples #8785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in N should be 1 - the total number of samples, because we also include 0. For example, if NUMBER_SAMPLES is 3 and MAX_N is 10, the three should be at n= 0, 5, and 10 so the diff between them should be 5 = 10 / (3 - 1).
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in N should be 1 - the total number of samples, because we also include 0. For example, if NUMBER_SAMPLES is 3 and MAX_N is 10, the three should be at n= 0, 5, and 10 so the diff between them should be 5 = 10 / (3 - 1).
References
None
Code changes
Fixes bug in benchmark code
User-facing changes
None
Backwards-incompatible changes
None