Fix workspace reset functionality. #7106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
I tried it out on the PR binder, and while it fixes everything up to point 8 in the issue, the optional point 9 is still broken. |
|
I.e. the automatic persistence of the workspace seems to be broken after a reset. |
|
Hm. Back to the drawing board. Let's see. |
|
Hm, this seems to work for me both on Binder and locally. |
3 tasks
|
Note: update changelog if this is merged: #7111 |
vidartf
reviewed
Aug 28, 2019
| const cleared = db | ||
| .clear() | ||
| .then(() => save.invoke()) | ||
| .then(() => router.stop); |
There was a problem hiding this comment.
I'm guessing this save turned out to be redundant now, if you wanted to clean that up :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #7105
Code changes
Saves the state database to the server after a user reset.
User-facing changes
N/A
Backwards-incompatible changes
N/A