-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase tab width by 50%. #4801
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks all right to me. Thanks. I'll merge, and @tgeorgeux or @ellisonbg, please comment if you'd rather it be tweaked/changed. |
Fine that this got merged, but please remember to include screenshots of
anything that includes a visual design change ;-)
…On Thu, Jun 28, 2018 at 10:54 PM Jason Grout ***@***.***> wrote:
Merged #4801 <#4801>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4801 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABr0JlCq91nSKlm-0WMahhLxHjbtIJcks5uBcElgaJpZM4U7ywj>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
@ellisonbg |
Thanks! The only thing that isn't clear is that in Chrome, the tabs start
that side but shrink if there are lots of them. Because we don't have
auto-shrinking implemented, we may find that width to be too much when
there are many open. But I think we should give this a shot and get
feedback from users. I wonder how difficult it would be to implement auto
tab sizing?
…On Fri, Jun 29, 2018 at 9:57 AM Ian Rose ***@***.***> wrote:
@ellisonbg <https://github.com/ellisonbg>
Before:
[image: image]
<https://user-images.githubusercontent.com/5728311/42104677-63761358-7b82-11e8-9836-c4e2ad1dd455.png>
After:
[image: image]
<https://user-images.githubusercontent.com/5728311/42104792-c6457d34-7b82-11e8-9186-43bec2b2cdc1.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4801 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABr0Ox-iooBAFRO8f2rjNLnHvOUuWNXks5uBlyEgaJpZM4U7ywj>
.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
We have autoshrinking if there are too many. That's why there is a min-width as well as a natural base size: https://github.com/jupyterlab/jupyterlab/pull/4801/files#diff-20c095f9c6bf0094b3429901c78d706bR50 |
Nice! I need to use JupyterLab more ;-)
…On Mon, Jul 2, 2018 at 5:28 PM Jason Grout ***@***.***> wrote:
We have autoshrinking if there are too many. That's why there is a min-width as well as a max-width.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
--
Brian E. Granger
Associate Professor of Physics and Data Science
Cal Poly State University, San Luis Obispo
@ellisonbg on Twitter and GitHub
bgranger@calpoly.edu and ellisonbg@gmail.com
|
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pkg:application
status:resolved-locked
Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
tag:Design and UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2378.
Increases the maximum tab width by 50%, from 144px to 216px. This roughly matches the tab widths in Firefox and Chrome (using the eyeball norm).
cc @tgeorgeux