Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kernel completion provider assumptions #14505

Merged
merged 2 commits into from
May 8, 2023
Merged

Fix kernel completion provider assumptions #14505

merged 2 commits into from
May 8, 2023

Conversation

krassowski
Copy link
Member

References

Fixes #14500

Code changes

  • Checks if response.metadata._jupyter_types_experimental is defined
  • Adds a test for KernelCompleterProvider.fetch

User-facing changes

Kernel completion suggestions in IRkernel work again.

Backwards-incompatible changes

None

krassowski added 2 commits May 7, 2023 14:46
@krassowski
Add a test for KernelCompleterProvider.fetch
d8e9fc4
@krassowski
Do not require types metadata
e5af53f 
Fixes kernel completion provider regression for IRKernel
and other kernels which do not provide types information
@krassowski krassowski added the bug label May 7, 2023
@krassowski krassowski added this to the 4.0.0 milestone May 7, 2023
@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@krassowski krassowski changed the title Fix kernel provider assumptions Fix kernel completion provider assumptions May 7, 2023
@afshin afshin mentioned this pull request May 7, 2023
Closed
afshin
afshin approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@afshin afshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@afshin afshin added the tag:Regression Behavior that had been broken, was fixed, and is broken again label May 7, 2023
@krassowski krassowski merged commit 022ef77 into jupyterlab:master May 8, 2023
@andrii-i andrii-i mentioned this pull request May 24, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@afshin afshin afshin approved these changes

Assignees

@krassowski krassowski

Labels
bug pkg:completer tag:Regression Behavior that had been broken, was fixed, and is broken again
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Tab completion not working on 4.0.x with IRKernel
2 participants
@krassowski @afshin