Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/duplicate-statement #11082

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

fcollonval
Copy link
Member

Remove duplicate statements

User changes

N/A

Breaking changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 added this to the 4.0 milestone Sep 15, 2021
@github-actions
Copy link
Contributor

Benchmark report

The execution time (in milliseconds) are grouped by test file, test type and browser.
For each case, the following values are computed: min <- [1st quartile - median - 3rd quartile] -> max.

Results table
Test file large_code_notebook large_md_notebook
open
chromium
actual 7390 <- [8165 - 8367 - 8648] -> 9407 4013 <- [4215 - 4385 - 4513] -> 5263
expected 6938 <- [7584 - 7618 - 7760] -> 8204 3461 <- [3524 - 3534 - 3590] -> 4136
switch-from
chromium
actual 477 <- [518 - 534 - 570] -> 609 344 <- [376 - 383 - 401] -> 463
expected 464 <- [480 - 489 - 499] -> 789 310 <- [338 - 344 - 352] -> 370
switch-to
chromium
actual 1795 <- [1883 - 1940 - 1996] -> 2049 1680 <- [1715 - 1747 - 1765] -> 1810
expected 1706 <- [1730 - 1764 - 1814] -> 2015 1541 <- [1549 - 1562 - 1574] -> 1608
close
chromium
actual 5946 <- [6871 - 8340 - 12724] -> 21265 3571 <- [3978 - 4334 - 4603] -> 5162
expected 5176 <- [5770 - 10533 - 14493] -> 18824 3325 <- [3691 - 3890 - 3939] -> 4073

❗ Test metadata have changed
--- /dev/fd/63	2021-09-15 10:16:19.355408464 +0000
+++ /dev/fd/62	2021-09-15 10:16:19.351408411 +0000
@@ -8,33 +8,33 @@
   },
   "systemInformation": {
     "cpu": {
-      "brand": "Xeon® E5-2673 v4",
+      "brand": "Xeon® Platinum 8171M",
       "cache": {
         "l1d": 65536,
         "l1i": 65536,
-        "l2": 524288,
-        "l3": 52428800
+        "l2": 2097152,
+        "l3": 36700160
       },
       "cores": 2,
       "family": "6",
-      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+      "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm mpx avx512f avx512dq rdseed adx smap clflushopt avx512cd avx512bw avx512vl xsaveopt xsavec xsaves md_clear",
       "governor": "",
       "manufacturer": "Intel®",
-      "model": "79",
+      "model": "85",
       "physicalCores": 2,
       "processors": 1,
       "revision": "",
       "socket": "",
-      "speed": 2.3,
+      "speed": 2.6,
       "speedMax": null,
       "speedMin": null,
-      "stepping": "1",
+      "stepping": "4",
       "vendor": "GenuineIntel",
       "virtualization": false,
       "voltage": ""
     },
     "mem": {
-      "total": 7291699200
+      "total": 7291695104
     },
     "osInfo": {
       "arch": "x64",
@@ -42,11 +42,11 @@
       "codename": "Focal Fossa",
       "codepage": "UTF-8",
       "distro": "Ubuntu",
-      "kernel": "5.8.0-1041-azure",
+      "kernel": "5.8.0-1040-azure",
       "logofile": "ubuntu",
       "platform": "linux",
       "release": "20.04.3 LTS",
-      "serial": "faac5b9e00cf4ae3b2d2c013e98d933a",
+      "serial": "0f5fd491ff264b5f9d56e03599b4fae0",
       "servicepack": "",
       "uefi": false
     }

@blink1073 blink1073 merged commit 69adf79 into jupyterlab:master Sep 15, 2021
@fcollonval fcollonval deleted the fix/duplicate-statement branch September 15, 2021 13:05
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Mar 15, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance pkg:notebook status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants