Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the non-null assertion on IDebugger.ISources #10976

Conversation

fcollonval
Copy link
Member

References

Fix #10975

Code changes

debugger state will have empty cells list if the debugger source is not available.

User-facing changes

N/A

Backwards-incompatible changes

N/A

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio
Copy link
Member

jtpio commented Aug 31, 2021

Looks like the failing UI tests check is not relevant?

@blink1073 blink1073 added the bug label Aug 31, 2021
@blink1073 blink1073 added this to the 4.0 milestone Aug 31, 2021
@fcollonval
Copy link
Member Author

Looks like the failing UI tests check is not relevant?

I confirm it is not relevant.

@jtpio jtpio merged commit a38c461 into jupyterlab:master Aug 31, 2021
@jtpio
Copy link
Member

jtpio commented Aug 31, 2021

Thanks!

@fcollonval fcollonval deleted the fix/Remove-the-non-null-assertion-on-`IDebuggerISources` branch December 20, 2021 10:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the non-null assertion on IDebugger.ISources
3 participants