Add "menu" context for translation of menu labels #10932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
|
@meeseeksdev please backport to 3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 31, 2021
blink1073
pushed a commit
that referenced
this pull request
Aug 31, 2021
…#10977) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
This is a follow up after #10931 and jupyterlab/jupyterlab-translate#8 adding "menu" context to the menu labels. This is needed for the translations to work (we lost the strings in pot file in transition the schema-based menus, and when re-introducing the them we decided to improve the translation context; this allows for example to translate "Edit" as "Edycja" (noun) for menu but "Edytuj" (verb) in another context, as appropriate.
Code changes
Use
_palias.User-facing changes
It is the penultimate change needed to make the language packs cover all JupyterLab GUI 🤞
Backwards-incompatible changes
None (current language packs are missing labels for menus).