Workaround invasive use of tex mode inside of code elements and blocks #10867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making a pull request to JupyterLab! To try out this branch on binder, follow this link: |
This was referenced Aug 18, 2021
|
I added two visual tests, one for latex highlighting and one for the bug being fixed:
|
|
Thx so much @krassowski for this! Big, big improvement to something that's been nagging many of us for a while. Much appreciated! I'm far from an expert in the Codemirror TS code, but from a quick look at the changes, given how limited in scope they are, this looks very good - the actual functional changes are tight and simple, and most of the new code in the PR is tests and examples. So from a semi-outsider view, this looks solid, thanks again! |
|
@meeseeksdev please backport to 3.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/jupyterlab
that referenced
this pull request
Aug 24, 2021
…ide of code elements and blocks
blink1073
pushed a commit
that referenced
this pull request
Aug 24, 2021
…e elements and blocks (#10901) Co-authored-by: Michał Krassowski <5832902+krassowski@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #6774
Code changes
Prevent multiplexing mode from applying tex mode inside of code blocks by re-delegating parsing in those instances back to
gfmModeparser.User-facing changes
Backwards-incompatible changes
None