Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for Real Time Collaboration #10547

Merged
merged 6 commits into from
Jul 7, 2021

Conversation

hbcarlos
Copy link
Member

@hbcarlos hbcarlos commented Jul 6, 2021

Documentation for Real Time Collaboration.

Also updated other parts of the documentation like JupyterLab URLs:

  • I think JupyterLab doesn't start in single-mode by default
  • Now we can open a Notebook in two tabs simultaneously.

References

Fixes #10227

Code changes

User-facing changes

Backwards-incompatible changes

@jupyterlab-dev-mode
Copy link

Thanks for making a pull request to JupyterLab!

To try out this branch on binder, follow this link: Binder

@hbcarlos hbcarlos marked this pull request as draft July 6, 2021 09:55
@blink1073 blink1073 added this to the 3.1 milestone Jul 6, 2021
@krassowski
Copy link
Member

How users should access the link to share the session? Should they install the jupyterlab-link-share extension? Should it be moved into the core? See #5382 (comment) (I think it is a common question).

@hbcarlos
Copy link
Member Author

hbcarlos commented Jul 6, 2021

Thanks for pointing that out, @krassowski. I completely forgot to mention it in the documentation.

There is a "Copy Shareable Link" entry on the context menu. I'll add to the documentation.
Edit: Actually, this one doesn't have the token.
share-link

@krassowski
Copy link
Member

Maybe the easiest approach would be to add the token to it?

@hbcarlos
Copy link
Member Author

hbcarlos commented Jul 7, 2021

Yes, I'll open an issue to track this and the corresponding PR.

@hbcarlos hbcarlos mentioned this pull request Jul 7, 2021
@hbcarlos hbcarlos marked this pull request as ready for review July 7, 2021 14:26
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple suggestions.

hbcarlos and others added 2 commits July 7, 2021 17:26
Co-authored-by: Steven Silvester <ssilvester@apple.com>
Co-authored-by: Steven Silvester <ssilvester@apple.com>
@hbcarlos
Copy link
Member Author

hbcarlos commented Jul 7, 2021

Thanks, Steven!

The link check test fails because I added a new file, rtc.rst, so the "Edit on GitHub" link from Read the Docs doesn't work.

@blink1073 blink1073 merged commit 21d5944 into jupyterlab:master Jul 7, 2021
@hbcarlos hbcarlos deleted the rtc-docs branch July 7, 2021 16:15
@github-actions github-actions bot added the status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. label Jan 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation status:resolved-locked Closed issues are locked after 30 days inactivity. Please open a new issue for related discussion. tag:Real Time Collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Update docs on real time collaboration
4 participants