Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open external links in system browser #883

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Open external links in system browser #883

wants to merge 2 commits into from

Conversation

ozellpaukert
Copy link

This solves #618.

@ozellpaukert
Copy link
Author

Found a problem with this implementation. If you click "Open in Notebook", then it will open notebook in system browser instead of jupyterlab-desktop.

@ozellpaukert
Copy link
Author

While working on this I discovered another problem (that is also present in the upstream):

  1. Opening jupyter notebook from jupyter lab creates a window that is not decorated like main labview
  2. Opening external links in jupyter windows opened from jupyter labs doesn't use system browser
  3. Opening jupyter lab from jupyter notebook creates an undecorated window

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ozellpaukert