Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install instructions to use correct name #166

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Conversation

fperez
Copy link
Contributor

@fperez fperez commented Jun 15, 2023

The actual package name (on both PyPI and conda-forge) is jupyter-collaboration with a -, not a _.

The actual package name (on both PyPI and conda-forge) is `jupyter-collaboration` with a `-`, not a `_`.
@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch jupyterlab/jupyter_collaboration/fperez-patch-1

@fperez
Copy link
Contributor Author

fperez commented Jun 15, 2023

#159 fixed the README but missed the docs. I agree with @martinRenou that it might be worth renaming the repo as well to stay consistent.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (b535c40) 41.42% compared to head (0412647) 41.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   41.42%   41.42%           
=======================================
  Files           8        8           
  Lines         548      548           
  Branches       75       75           
=======================================
  Hits          227      227           
  Misses        317      317           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fperez fperez added the documentation Improvements or additions to documentation label Jun 15, 2023
Copy link
Collaborator

@davidbrochart davidbrochart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fperez !

@davidbrochart davidbrochart merged commit 0ff1f7c into main Jun 15, 2023
@davidbrochart davidbrochart deleted the fperez-patch-1 branch June 15, 2023 06:48
@davidbrochart
Copy link
Collaborator

I also renamed the repo.

@fperez
Copy link
Contributor Author

fperez commented Jun 15, 2023

Great, thx for the quick turnaround!

@jupyterlab jupyterlab deleted a comment from welcome bot Jun 15, 2023
@jupyterlab jupyterlab deleted a comment from welcome bot Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants