Fix metadata #138
Merged
Fix metadata #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 7 7
Lines 418 408 -10
=====================================
+ Misses 418 408 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
@hbcarlos I would appreciate if you give me a bit of time to be able to review, instead of merging your own PR. |
|
@davidbrochart @hbcarlos what do you think of adding a rule requiring an approved review to allow merge (I guess we should also do the same on jupyter_ydoc)? |
|
Yes I think it would be useful, here and in jupyter-ydoc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates jupyter_ydoc to fix an issue with the YNotebook. See jupyter-server/jupyter_ydoc#158
Follow up #121 :