Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creates a new FileLoader class to separate the logic of watching files #121

Merged
merged 25 commits into from
Apr 11, 2023
Merged

Creates a new FileLoader class to separate the logic of watching files #121

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
032deac
Split code in multiple files
hbcarlos Mar 13, 2023
b294583
Uses new rooms with file loader
hbcarlos Mar 14, 2023
0b20530
Uses the new FileLoader
hbcarlos Mar 23, 2023
b987795
Add observer pattern for notifying room
hbcarlos Mar 24, 2023
c6a7e03
Fixes watching files and cleaning rooms
hbcarlos Mar 26, 2023
e1b8304
Uses locks to make sure only one client initializes the room
hbcarlos Mar 28, 2023
637f1b9
Clean up before shut down
hbcarlos Mar 28, 2023
a473408
Review: room lock private and scoped config variables
hbcarlos Mar 28, 2023
5d6475a
Review: use Logger | None
hbcarlos Mar 29, 2023
57b660b
Review: save condition, load lock and iterate over subscriptions
hbcarlos Mar 29, 2023
931a4a0
Fix file lock
hbcarlos Mar 31, 2023
06cef69
Uses file_id instead of paths
hbcarlos Mar 31, 2023
df564d6
lint
hbcarlos Apr 3, 2023
3acfe12
Ignore type error
hbcarlos Apr 3, 2023
32a4931
Lint
hbcarlos Apr 3, 2023
2103311
Review: Freds comments
hbcarlos Apr 4, 2023
6aa4eb6
Lint
hbcarlos Apr 4, 2023
4a23f8f
Warn users about opening multiple view for the same file
hbcarlos Apr 4, 2023
ed045ed
Adds docstring
hbcarlos Apr 5, 2023
78c340c
More docstring
hbcarlos Apr 5, 2023
1ee3848
Fixes sync between rooms
hbcarlos Apr 7, 2023
ed54891
Lint
hbcarlos Apr 7, 2023
ac92018
Improves sync
hbcarlos Apr 11, 2023
0ce6b05
flake
hbcarlos Apr 11, 2023
91cd8a8
Revert default settings changes
hbcarlos Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion jupyter_collaboration/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
from traitlets import Float, Int, Type
from ypy_websocket.ystore import BaseYStore

from .handlers import DocSessionHandler, SQLiteYStore, YDocWebSocketHandler
from .handlers import DocSessionHandler, YDocWebSocketHandler
from .stores import SQLiteYStore


class YDocExtension(ExtensionApp):
Expand Down Expand Up @@ -61,3 +62,6 @@ def initialize_handlers(self):
(r"/api/collaboration/session/(.*)", DocSessionHandler),
]
)

async def stop_extension(self):
YDocWebSocketHandler.clean_up()
Loading