Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds side panel widgets to the tracker #146

Merged
merged 5 commits into from
Feb 6, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Jan 7, 2025

Add the side panel chats to the widget tracker.

Fixes #130
Fixes #139

The chats tracker tracks both LabChatPanel (the main area widget) and ChatWidget (widget in the side panel).

IMPROVEMENT

  • The layout restorer is now able to open back the chats in the main area and in the side panel.
  • The shortcut to focus on the chat input (Accel Shift 1) works for all the chat widgets. The last used input is focused.
  • EDIT: the chat input is focussed when clicking anywhere on the chat except on a focusable element.

TO DO

  • improve the tracking of the chat widget
    The widget become the current widget of the tracker only if an input has been clicked. We should focus on the input component when the chat is clicked (anywhere except on an other input). This would also be a nice UX improvement.
  • add tests on it

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/side-panel-chats-tracker

@brichet brichet added enhancement New feature or request chat extension labels Jan 7, 2025
@brichet brichet marked this pull request as ready for review January 7, 2025 17:24
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brichet Looks good, thank you for building this! Tested your PR locally and it seems to work well. 🎉 Just left a few extra comments which don't block this PR.

@brichet brichet force-pushed the side-panel-chats-tracker branch from dfc1365 to 945d591 Compare February 6, 2025 08:11
@brichet brichet merged commit ff01015 into jupyterlab:main Feb 6, 2025
12 checks passed
@brichet brichet deleted the side-panel-chats-tracker branch February 6, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chat extension enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard shortcuts: fix warnings and add one for focusing chat input Add tracker for chats in side panel
3 participants