Add a /clear command to clear the chat history #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3coins
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
@ellisonbg
Thanks for adding this feature.
There are some minor suggestions for improvement, but we can merge and iterate if you don't have time.
|
|
||
| actor.process_message.remote(message) | ||
| actor.process_message.remote(message) | ||
| if command == '/clear': |
There was a problem hiding this comment.
Rather than having a special check here, should we just add this to the commands?
There was a problem hiding this comment.
I didn't want to use an actor, but we can figure out how to improve this.
| @@ -247,6 +244,12 @@ async def on_message(self, message): | |||
| # broadcast the message to other clients | |||
| self.broadcast_message(message=chat_message) | |||
|
|
|||
| # Clear the message history if given the /clear command | |||
| if chat_request.prompt.startswith('/'): | |||
| command = chat_request.prompt.split(' ', 1)[0] | |||
There was a problem hiding this comment.
Will help to extract the split code into a utility function that can be reused everywhere, but can do this in another PR.
dbelgrod
pushed a commit
to dbelgrod/jupyter-ai
that referenced
this pull request
Jun 10, 2024
* Initial draft of /clear command. * Finish implementation of /clear. * Remove extra console.log.
Marchlak
pushed a commit
to Marchlak/jupyter-ai
that referenced
this pull request
Oct 28, 2024
* Initial draft of /clear command. * Finish implementation of /clear. * Remove extra console.log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a /clear command that clears the chat history, but leaves the memory intact.