Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade extensions for JupyterLab 3.0 #119

Merged
merged 8 commits into from
Sep 15, 2020

Conversation

blink1073
Copy link
Contributor

@blink1073 blink1073 commented Sep 9, 2020

Fixes #115

Also adds a script that can be used in the future to upgrade the extensions: scripts/upgrade_extensions.py.
I verified that re-running the script made no further changes.

063679a and 55ea69b demonstrate upgrading a server extension. The first commit is the auto-upgrade of the package.json file, and the second is the result of manually upgrading the files as prompted by the upgrade script.

@blink1073
Copy link
Contributor Author

cc @goanpeca

@goanpeca
Copy link
Member

Thanks @blink1073 :-)

@blink1073 blink1073 changed the title [WIP] Upgrade extensions for JupyterLab 3.0 Upgrade extensions for JupyterLab 3.0 Sep 11, 2020
Upgrade extensions for JupyterLab 3.0

debug

pin nbconvert for now

use nbconvert 5.6

fix uninstall method

install jupyter-packaging

Update server extension readme and use nbconvert 5.6

fix usages of serverextension commands

Update readmes

install latest pip

remove nbconvert pin

use verbose install

try to force a true response in pip install

switch to editable install

try to force a true response in pip install

debug print

add more debug info

use insensitive check

Add upgrade script

Remove unused jupyter-config files

clean up script

update server

cleanup

install --pre jupyterlab

integrity
@blink1073
Copy link
Contributor Author

This is good to go!

@blink1073
Copy link
Contributor Author

I'm seeing random failures due to yarnpkg.com timeouts

@jtpio
Copy link
Member

jtpio commented Sep 14, 2020

Nice, thanks Steve!

Restarted the CI jobs and everything is green. This looks good to go so other PRs could target the 3.0 branch.

@jtpio
Copy link
Member

jtpio commented Sep 14, 2020

Maybe we'll want to also add a CI step that checks the new files such as pyproject.toml and setup.py are in sync, similar to this one:

diff basics/hello-world/tsconfig.json ${EXAMPLE_FOLDER}/tsconfig.json
diff basics/hello-world/.eslintignore ${EXAMPLE_FOLDER}/.eslintignore
diff basics/hello-world/.eslintrc.js ${EXAMPLE_FOLDER}/.eslintrc.js
diff basics/hello-world/.gitignore ${EXAMPLE_FOLDER}/.gitignore

Although this might require using a custom script since the name of the extensions are also part of the setup.py file, and a plain diff might not be enough.

Something we could track in a separate issue.

@blink1073
Copy link
Contributor Author

blink1073 commented Sep 14, 2020

We could actually run the script/upgrade_extensions.py and see if any files change in git status. How does that sound?

@goanpeca
Copy link
Member

Got for it :-)

@jtpio
Copy link
Member

jtpio commented Sep 14, 2020

Sounds good 👍

@jtpio jtpio merged commit ab5aefa into jupyterlab:3.0 Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants