-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade extensions for JupyterLab 3.0 #119
Conversation
cc @goanpeca |
Thanks @blink1073 :-) |
Upgrade extensions for JupyterLab 3.0 debug pin nbconvert for now use nbconvert 5.6 fix uninstall method install jupyter-packaging Update server extension readme and use nbconvert 5.6 fix usages of serverextension commands Update readmes install latest pip remove nbconvert pin use verbose install try to force a true response in pip install switch to editable install try to force a true response in pip install debug print add more debug info use insensitive check Add upgrade script Remove unused jupyter-config files clean up script update server cleanup install --pre jupyterlab integrity
5a4689c
to
8099ef9
Compare
This is good to go! |
I'm seeing random failures due to yarnpkg.com timeouts |
Nice, thanks Steve! Restarted the CI jobs and everything is green. This looks good to go so other PRs could target the |
Maybe we'll want to also add a CI step that checks the new files such as extension-examples/.github/workflows/main.yml Lines 47 to 50 in e7054af
Although this might require using a custom script since the name of the extensions are also part of the Something we could track in a separate issue. |
We could actually run the |
Got for it :-) |
Sounds good 👍 |
Fixes #115
Also adds a script that can be used in the future to upgrade the extensions:
scripts/upgrade_extensions.py
.I verified that re-running the script made no further changes.
063679a and 55ea69b demonstrate upgrading a server extension. The first commit is the auto-upgrade of the
package.json
file, and the second is the result of manually upgrading the files as prompted by the upgrade script.