fix support for projects with different python/labextension_name
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I just ran into another breaking bug in the new hatch toml. This is hidden if the names of the project's python and js packages are exactly the same. However, when I made a project with python package `jupyterlab_x_y` and js package `jupyterlab-x-y` I ran into pathing hell. Ultimately the issue in this case is that the javascript machinery that loads the extension bundle files expect all of the files to be under a dir named after the js package (eg `share/jupyter/labextensions/jupyterlab-x-y`), but the toml template instead places the bundle files under a dir named after the python package (eg `share/jupyter/labextensions/jupyterlab_x_y`). This leads to a fatal NOT-FOUND error on attempted extension bundle load. This PR fixes that
python'/'labextension_namepython/labextension_name
fcollonval
approved these changes
Sep 12, 2022
There was a problem hiding this comment.
Thanks @telamonian
One of the test is using my-labextension and my_labextension and did not catch this. Could you provide more details on when and where is the error emitted so we can make the CI test more robust?
|
Thanks, merging since it fixes the original issue. Opened #232 to track follow-up CI improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into another breaking bug in the new hatch toml. This is hidden if the names of the project's python and js packages are exactly the same. However, when I made a project with python package
jupyterlab_x_yand js packagejupyterlab-x-yI ran into pathing hell. Ultimately the issue in this case is that the javascript machinery that loads the extension bundle files expect all of the files to be under a dir named after the js package (egshare/jupyter/labextensions/jupyterlab-x-y), but the toml template instead places the bundle files under a dir named after the python package (egshare/jupyter/labextensions/jupyterlab_x_y). This leads to a fatal NOT-FOUND error on attempted extension bundle load. This PR fixes that