Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Fix handling of source breakpoints #556

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 12, 2020

Fixes #555

Follow-up to #514 and jupyter-xeus/xeus-python#314, so the debugger frontend can handle the debug info reply properly.

@jtpio jtpio marked this pull request as draft October 12, 2020 20:54
@jtpio
Copy link
Member Author

jtpio commented Oct 13, 2020

Marked as draft for now as this issue is not happening in core lab.

It looks like it is related to the strict null checks (enabled in core but not here).

@jtpio
Copy link
Member Author

jtpio commented Oct 13, 2020

Which means we should move forward with archiving this repo since the code bases have diverged.

@jtpio jtpio marked this pull request as ready for review October 14, 2020 10:15
@jtpio
Copy link
Member Author

jtpio commented Oct 14, 2020

Let's get it in so the patch can be part of 0.3.4.

@jtpio jtpio merged commit dc9e6f9 into jupyterlab:master Oct 14, 2020
@jtpio jtpio deleted the source-breakpoints branch October 14, 2020 10:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BreakpointCellComponent error with xeus-python 0.8.6
1 participant