This repository was archived by the owner on Jan 26, 2022. It is now read-only.
Extra breakpoint after typing with refresh kernel. #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtpio
reviewed
May 7, 2020
src/breakpoints/model.ts
Outdated
| @@ -85,8 +91,38 @@ export class BreakpointsModel implements IDisposable { | |||
| } | |||
|
|
|||
| private _isDisposed = false; | |||
| private _statesOfCell = new Map<string, string>(); | |||
There was a problem hiding this comment.
Do we need to keep track of extra state?
d62c799 to
78a81eb
Compare
|
It looks like the diff shows changes from other merged PRs. Should we copy the changes over to another new PR rebased on the latest maybe? |
|
Closing in favor of #454 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My latest proposal to solve the problem. The solution is the implementation of the idea @JohanMabille.
#414 (comment)
Thanks for help.
What remains to be done.
I could delete the States class and send parameters directly, however they are correlated with cells. That's why I did it.
The second important thing that I haven't solved here is restoring points after refreshing the browser.
Naturally, the map is cleared, so it won't work in this case.
However, when refreshing the kernel, it seems to work.
The conclusion that comes to me. Some way to load breakpoints and create their map immediately after refreshing the browser.
I'm not sure about the final appearance updateBreakpoints method into service.
Any comments and suggestions?